Deleting a post, editing media out, replacing an avatar or a header, and removing a whole root deleted no file: every one stayed on disk and publicly served from /media/files with a year-long immutable cache, its row orphaned. Now every upload is a row, profile pictures too (Kind avatar or header, ProfileOfAvatarId), and each of those acts trashes what it held, as does an upload never posted for a day and a dropped scheduled post. A trashed row is marked in one conditional update (an upload attached meanwhile is left alone), its files move into media-trash, beside the media root and outside what /media/files serves, and the janitor deletes them a day later. Nothing is deleted for looking unused. Along the way: a profile picture that isn't an image, or can't be read, answers 422 instead of being silently ignored with a 200; a removed root's scheduled posts are dropped, so nothing of it publishes later; media rows get indexes (they had none), and the janitor's first pass comes five minutes after boot instead of an hour. `PrivaPub admin media audit [--fix]` compares the disk with the database. With --fix (as www-data) it gives the pictures personas show today a row, and trashes media of deleted posts or personas, rows whose files are missing, and files nothing holds: the leftovers of every deletion until now. MediaLifecycleTests covers each act, that the trash is never served, and the audit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LsXgEaXee4GCU1hwYgPJXw
167 lines
7.1 KiB
C#
167 lines
7.1 KiB
C#
using MongoDB.Entities;
|
|
|
|
using PrivaPub.ClientModels;
|
|
using PrivaPub.ClientModels.User;
|
|
using PrivaPub.ClientModels.User.Avatar;
|
|
using PrivaPub.Models.User;
|
|
using PrivaPub.Services;
|
|
using PrivaPub.Services.ClientToServer.Private;
|
|
using PrivaPub.StaticServices;
|
|
|
|
using System.ComponentModel.DataAnnotations;
|
|
using System.Security.Cryptography;
|
|
|
|
namespace PrivaPub.Infrastructure.Cli
|
|
{
|
|
// `PrivaPub admin ...` runs with the whole server built but not started: no Kestrel, no hosted services.
|
|
public static class AdminCommands
|
|
{
|
|
public const string SmokeLogin = "deploy-smoke";
|
|
|
|
const string Usage = """
|
|
usage: PrivaPub admin promote|demote <root>
|
|
PrivaPub admin create-root <login> [--admin] the password is read from standard input
|
|
PrivaPub admin smoke <persona> prints "<login> <password>" for the deploy's signed-in check
|
|
PrivaPub admin media audit [--fix] media files against what holds them; --fix (as www-data) trashes
|
|
what nothing holds and gives today's pictures their rows
|
|
""";
|
|
|
|
public static async Task<int> Run(string[] args, IServiceProvider services, TextReader input = default, TextWriter output = default)
|
|
{
|
|
input ??= Console.In;
|
|
output ??= Console.Out;
|
|
switch (args)
|
|
{
|
|
case [("promote" or "demote") and var verb, var userName]:
|
|
return await Promote(verb == "promote", userName, output);
|
|
case ["create-root", var login, .. var flags] when flags.All(f => f == "--admin"):
|
|
return await CreateRoot(services, login, input.ReadLine(), flags.Contains("--admin"), output);
|
|
case ["smoke", var persona]:
|
|
return await Smoke(services, persona, output);
|
|
case ["media", "audit", .. var flags] when flags.All(f => f == "--fix"):
|
|
return await AuditMedia(services, flags.Contains("--fix"), output);
|
|
default:
|
|
Console.Error.WriteLine(Usage);
|
|
return 2;
|
|
}
|
|
}
|
|
|
|
static async Task<int> AuditMedia(IServiceProvider services, bool fix, TextWriter output)
|
|
{
|
|
var report = await Domain.Media.MediaAudit.Run(services.GetRequiredService<Domain.Media.IMediaService>(), fix, CancellationToken.None);
|
|
output.WriteLine($"{report.Files} files served, {report.Held} rows holding media");
|
|
output.WriteLine($"{report.Adopted} pictures personas show without a row{(fix ? ": given one" : string.Empty)}");
|
|
output.WriteLine($"{report.OfDeleted} media of deleted posts or personas{(fix ? ": trashed" : string.Empty)}");
|
|
output.WriteLine($"{report.MissingFiles} rows whose files are missing{(fix ? ": trashed" : string.Empty)}");
|
|
output.WriteLine($"{report.Unheld} files nothing holds{(fix ? ": trashed" : string.Empty)}");
|
|
foreach (var example in report.Examples)
|
|
output.WriteLine($" {example}");
|
|
if (!fix && report.Adopted + report.OfDeleted + report.MissingFiles + report.Unheld > 0)
|
|
output.WriteLine("run again with --fix, as www-data, to apply this; trashed files are deleted after a day");
|
|
return 0;
|
|
}
|
|
|
|
static async Task<int> Promote(bool promote, string userName, TextWriter output)
|
|
{
|
|
userName = userName.ToLowerInvariant();
|
|
var user = await DB.Default.Find<RootUser>().Match(u => u.UserName == userName).ExecuteFirstAsync();
|
|
if (user == default)
|
|
{
|
|
Console.Error.WriteLine($"no root user '{userName}'");
|
|
return 1;
|
|
}
|
|
|
|
user.Policies.RemoveAll(p => p is Policies.IsAdmin or Policies.IsModerator);
|
|
if (promote)
|
|
user.Policies.AddRange(new[] { Policies.IsAdmin, Policies.IsModerator });
|
|
if (!user.Policies.Contains(Policies.IsUser))
|
|
user.Policies.Add(Policies.IsUser);
|
|
user.UpdatedAt = DateTime.UtcNow;
|
|
await DB.Default.SaveAsync(user);
|
|
|
|
output.WriteLine($"{userName}: {string.Join(", ", user.Policies)}");
|
|
return 0;
|
|
}
|
|
|
|
// With sign-up closed this is how the first root is made; group invitations make the rest.
|
|
static async Task<int> CreateRoot(IServiceProvider services, string login, string password, bool admin, TextWriter output)
|
|
{
|
|
var form = new LoginForm { UserName = login, Password = password?.Trim() };
|
|
var problems = new List<ValidationResult>();
|
|
if (!Validator.TryValidateObject(form, new ValidationContext(form), problems, validateAllProperties: true))
|
|
{
|
|
Console.Error.WriteLine(string.Join(Environment.NewLine, problems.Select(p => p.ErrorMessage)));
|
|
return 1;
|
|
}
|
|
var created = await services.GetRequiredService<IRootUsersService>().SignUpAsync(form);
|
|
if (!created.IsValid)
|
|
{
|
|
Console.Error.WriteLine(created.ErrorMessage);
|
|
return 1;
|
|
}
|
|
return admin ? await Promote(true, login, output) : await Report(login, output);
|
|
}
|
|
|
|
static Task<int> Report(string login, TextWriter output)
|
|
{
|
|
output.WriteLine($"{login.ToLowerInvariant()}: created");
|
|
return Task.FromResult(0);
|
|
}
|
|
|
|
// The deploy's signed-in smoke check: a root nobody signs in to by hand, owning one undiscoverable persona. Every run
|
|
// sets a new password and prints it, so no secret is kept anywhere and nothing waits on a person.
|
|
static async Task<int> Smoke(IServiceProvider services, string personaName, TextWriter output)
|
|
{
|
|
personaName = personaName.ToLowerInvariant();
|
|
var password = "Smoke-x" + Convert.ToHexStringLower(RandomNumberGenerator.GetBytes(24));
|
|
var root = await DB.Default.Find<RootUser>().Match(u => u.UserName == SmokeLogin).ExecuteFirstAsync();
|
|
if (root == default)
|
|
{
|
|
var created = await services.GetRequiredService<IRootUsersService>().SignUpAsync(new LoginForm { UserName = SmokeLogin, Password = password });
|
|
if (!created.IsValid)
|
|
{
|
|
Console.Error.WriteLine(created.ErrorMessage);
|
|
return 1;
|
|
}
|
|
root = await DB.Default.Find<RootUser>().Match(u => u.UserName == SmokeLogin).ExecuteFirstAsync();
|
|
}
|
|
else if (root.DeletedAt.HasValue || root.IsBanned)
|
|
{
|
|
Console.Error.WriteLine($"the root '{SmokeLogin}' is deleted or banned");
|
|
return 1;
|
|
}
|
|
else
|
|
await DB.Default.Update<RootUser>().MatchID(root.ID)
|
|
.Modify(u => u.HashedPassword, services.GetRequiredService<IPasswordHasher>().Hash(password))
|
|
.Modify(u => u.UpdatedAt, DateTime.UtcNow)
|
|
.ExecuteAsync();
|
|
|
|
var owned = (await DB.Default.Find<RootToAvatar>().Match(ra => ra.RootId == root.ID).ExecuteAsync()).Select(ra => ra.AvatarId).ToList();
|
|
var persona = await DB.Default.Find<Avatar>().Match(a => owned.Contains(a.ID) && a.UserName == personaName && !a.DeletionAt.HasValue).ExecuteFirstAsync();
|
|
if (persona == default)
|
|
{
|
|
var inserted = await services.GetRequiredService<IPrivateAvatarUsersService>().InsertAvatar(new InsertAvatarForm
|
|
{
|
|
RootId = root.ID,
|
|
UserName = personaName,
|
|
Name = personaName,
|
|
Biography = "The deploy signs in here to check that the Mastodon API works for a signed-in persona."
|
|
});
|
|
if (!inserted.IsValid)
|
|
{
|
|
Console.Error.WriteLine(inserted.ErrorMessage);
|
|
return 1;
|
|
}
|
|
persona = await DB.Default.Find<Avatar>().MatchID(((ViewAvatar)inserted.Data).Id).ExecuteFirstAsync();
|
|
}
|
|
await DB.Default.Update<Avatar>().MatchID(persona.ID)
|
|
.Modify(a => a.Settings.IsDiscoverable, false)
|
|
.Modify(a => a.Settings.IsIndexable, false)
|
|
.ExecuteAsync();
|
|
|
|
output.WriteLine($"{SmokeLogin} {password}");
|
|
return 0;
|
|
}
|
|
}
|
|
}
|