From 96d1db1008122b0fe3f178e20531d46b7a39366f Mon Sep 17 00:00:00 2001
From: thepra <thepra@pm.me>
Date: Sat, 3 Oct 2026 12:43:07 +0200
Subject: [PATCH] Fix logout, the client log store and empty name attributes

Logout:
- It navigated to "authenticatio/logout", a misspelled route.
- The correct template route, authentication/logout, would throw anyway. Its
  RemoteAuthenticatorView casts the AuthenticationStateProvider to the OIDC
  template's service, and the app registers TokenAuthStateProvider instead.
- It now signs out through TokenAuthStateProvider.LogoutAsync, as the code
  commented out in the page intended, and returns home. LoginDisplay's sign-out
  goes through it as well.
- This also drops the obsolete SignOutSessionStateManager, the build's last
  warning.

The IndexedDB schema never declared the ClientLogs store that IStorage.AddLog
writes to, so every client log write failed inside its try/catch. Version 2 adds
the store, keyed by the Id AddLog assigns.

DInputBase.NameAttribute renders no name instead of name="" when the form maps
no field names.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LsXgEaXee4GCU1hwYgPJXw
---
 Components/Daisy/DInputBase.cs             |  6 ++++++
 Components/Daisy/DataInput/DInput.razor    |  4 ++--
 Components/Daisy/DataInput/DOtp.razor      |  2 +-
 Components/Daisy/DataInput/DRange.razor    |  2 +-
 Components/Daisy/DataInput/DSelect.razor   |  4 ++--
 Components/Daisy/DataInput/DTextarea.razor |  2 +-
 Components/Daisy/DataInput/DToggle.razor   |  2 +-
 Extensions/GenericExtensions.cs            |  9 ++++++++-
 Pages/Logout.razor                         | 11 ++++++-----
 Shared/LoginDisplay.razor                  |  2 +-
 10 files changed, 29 insertions(+), 15 deletions(-)

diff --git a/Components/Daisy/DInputBase.cs b/Components/Daisy/DInputBase.cs
index 70604be..25384c0 100644
--- a/Components/Daisy/DInputBase.cs
+++ b/Components/Daisy/DInputBase.cs
@@ -20,6 +20,12 @@ public abstract class DInputBase<TValue> : InputBase<TValue>
 	protected IReadOnlyDictionary<string, object> InputAttributes =>
 		AdditionalAttributes?.Where(a => a.Key != "class").ToDictionary(a => a.Key, a => a.Value);
 
+	/// <summary>
+	/// The name attribute, or null so none is rendered. InputBase.NameAttributeValue is "" outside a form that maps
+	/// field names, which would group every radio and checkbox on the page.
+	/// </summary>
+	protected string NameAttribute => string.IsNullOrEmpty(NameAttributeValue) ? null : NameAttributeValue;
+
 	protected static string Cx(params string[] classes) => DCx.Join(classes);
 
 	protected override string FormatValueAsString(TValue value) =>
diff --git a/Components/Daisy/DataInput/DInput.razor b/Components/Daisy/DataInput/DInput.razor
index 63233bf..232630c 100644
--- a/Components/Daisy/DataInput/DInput.razor
+++ b/Components/Daisy/DataInput/DInput.razor
@@ -5,14 +5,14 @@
    moves to a wrapping <label>, as daisyUI requires when the field holds more than one element. *@
 @if (Prefix is null && Suffix is null)
 {
-	<input @attributes="InputAttributes" type="@Type" class="@CssClassFull" name="@NameAttributeValue"
+	<input @attributes="InputAttributes" type="@Type" class="@CssClassFull" name="@NameAttribute"
 		   value="@CurrentValueAsString" @oninput="OnInput" @onchange="OnChange" aria-invalid="@(IsInvalid ? "true" : null)" />
 }
 else
 {
 	<label class="@CssClassFull">
 		@Prefix
-		<input @attributes="InputAttributes" type="@Type" class="grow" name="@NameAttributeValue"
+		<input @attributes="InputAttributes" type="@Type" class="grow" name="@NameAttribute"
 			   value="@CurrentValueAsString" @oninput="OnInput" @onchange="OnChange" aria-invalid="@(IsInvalid ? "true" : null)" />
 		@Suffix
 	</label>
diff --git a/Components/Daisy/DataInput/DOtp.razor b/Components/Daisy/DataInput/DOtp.razor
index db63100..eb92b04 100644
--- a/Components/Daisy/DataInput/DOtp.razor
+++ b/Components/Daisy/DataInput/DOtp.razor
@@ -9,7 +9,7 @@
 		<span></span>
 	}
 	<input type="text" autocomplete="one-time-code" inputmode="numeric" required @attributes="InputAttributes"
-		   maxlength="@Digits" pattern="@($"[0-9]{{{Digits}}}")" name="@NameAttributeValue" value="@CurrentValueAsString"
+		   maxlength="@Digits" pattern="@($"[0-9]{{{Digits}}}")" name="@NameAttribute" value="@CurrentValueAsString"
 		   @oninput="OnInput" @onchange="OnChange" aria-invalid="@(IsInvalid ? "true" : null)" />
 </label>
 
diff --git a/Components/Daisy/DataInput/DRange.razor b/Components/Daisy/DataInput/DRange.razor
index 8ea0a4c..a04dc00 100644
--- a/Components/Daisy/DataInput/DRange.razor
+++ b/Components/Daisy/DataInput/DRange.razor
@@ -3,7 +3,7 @@
 
 @* daisyUI Range: https://daisyui.com/components/range/ . TValue is numeric; Min and Max are always rendered, as daisyUI
    requires. *@
-<input @attributes="InputAttributes" type="range" class="@CssClassFull" name="@NameAttributeValue" min="@Format(Min)"
+<input @attributes="InputAttributes" type="range" class="@CssClassFull" name="@NameAttribute" min="@Format(Min)"
 	   max="@Format(Max)" step="@(Step is null ? null : Format(Step.Value))" value="@CurrentValueAsString"
 	   @oninput="OnInput" @onchange="OnChange" aria-invalid="@(IsInvalid ? "true" : null)" />
 
diff --git a/Components/Daisy/DataInput/DSelect.razor b/Components/Daisy/DataInput/DSelect.razor
index b0671a0..5ee8fe4 100644
--- a/Components/Daisy/DataInput/DSelect.razor
+++ b/Components/Daisy/DataInput/DSelect.razor
@@ -5,7 +5,7 @@
    enums bind by name. With Prefix (an icon or a span.label) the select class moves to a wrapping <label>. *@
 @if (Prefix is null)
 {
-	<select @attributes="InputAttributes" class="@CssClassFull" name="@NameAttributeValue" value="@CurrentValueAsString"
+	<select @attributes="InputAttributes" class="@CssClassFull" name="@NameAttribute" value="@CurrentValueAsString"
 			@onchange="OnChange" aria-invalid="@(IsInvalid ? "true" : null)">
 		@ChildContent
 	</select>
@@ -14,7 +14,7 @@ else
 {
 	<label class="@CssClassFull">
 		@Prefix
-		<select @attributes="InputAttributes" name="@NameAttributeValue" value="@CurrentValueAsString" @onchange="OnChange"
+		<select @attributes="InputAttributes" name="@NameAttribute" value="@CurrentValueAsString" @onchange="OnChange"
 				aria-invalid="@(IsInvalid ? "true" : null)">
 			@ChildContent
 		</select>
diff --git a/Components/Daisy/DataInput/DTextarea.razor b/Components/Daisy/DataInput/DTextarea.razor
index 29ea641..e77c774 100644
--- a/Components/Daisy/DataInput/DTextarea.razor
+++ b/Components/Daisy/DataInput/DTextarea.razor
@@ -3,7 +3,7 @@
 
 @* daisyUI Textarea: https://daisyui.com/components/textarea/ . Blazor sets the textarea's value property, so the bound
    value is the content; rows, placeholder and the like pass through. *@
-<textarea @attributes="InputAttributes" class="@CssClassFull" name="@NameAttributeValue" value="@CurrentValueAsString"
+<textarea @attributes="InputAttributes" class="@CssClassFull" name="@NameAttribute" value="@CurrentValueAsString"
 		  @oninput="OnInput" @onchange="OnChange" aria-invalid="@(IsInvalid ? "true" : null)"></textarea>
 
 @code {
diff --git a/Components/Daisy/DataInput/DToggle.razor b/Components/Daisy/DataInput/DToggle.razor
index fd5ba39..1f7305f 100644
--- a/Components/Daisy/DataInput/DToggle.razor
+++ b/Components/Daisy/DataInput/DToggle.razor
@@ -39,7 +39,7 @@ else
 	string WrapperClass => Cx("toggle", IsInvalid ? "has-checked:[--input-color:var(--color-error)]" : WrapperColorClass, SizeClass, CssClass);
 
 	RenderFragment Checkbox(string cssClass) =>
-		@<input @attributes="InputAttributes" type="checkbox" class="@cssClass" name="@NameAttributeValue" checked="@CurrentValue"
+		@<input @attributes="InputAttributes" type="checkbox" class="@cssClass" name="@NameAttribute" checked="@CurrentValue"
 				@onchange="OnChange" aria-invalid="@(IsInvalid ? "true" : null)" />;
 
 	RenderFragment IconParts => @<text>
diff --git a/Extensions/GenericExtensions.cs b/Extensions/GenericExtensions.cs
index 72ab875..8ad1e9c 100644
--- a/Extensions/GenericExtensions.cs
+++ b/Extensions/GenericExtensions.cs
@@ -31,7 +31,7 @@ public static class GenericExtensions
 		{
 			var model = new IndexedDbDatabaseModel()
 				.WithName("data")
-				.WithVersion(1)
+				.WithVersion(2)
 				.WithModelId(1);
 
 			model.AddStore(nameof(Message))
@@ -45,6 +45,13 @@ public static class GenericExtensions
 				.AddIndex(nameof(Message.CreatedAt))
 				.AddIndex(nameof(Message.Medias));
 
+			// IStorage.AddLog numbers entries itself (max key + 1), so the key is Id rather than generated. Version 2
+			// added this store; before it, every log write failed inside AddLog's try/catch.
+			model.AddStore(nameof(ClientLogs))
+				.WithKey(nameof(ClientLogs.Id))
+				.AddUniqueIndex(nameof(ClientLogs.Id))
+				.AddIndex(nameof(ClientLogs.TimeStamp));
+
 			options.UseDatabase(model);
 		});
 	}
diff --git a/Pages/Logout.razor b/Pages/Logout.razor
index fd2c693..d83cb86 100644
--- a/Pages/Logout.razor
+++ b/Pages/Logout.razor
@@ -12,14 +12,15 @@
 
 @code {
 	[CascadingParameter] CascadingState CascadingState { get; set; }
-	//[Inject] TokenAuthStateProvider AuthStateProvider { get; set; }
-	[Inject] SignOutSessionStateManager SignOutSessionStateManager { get; set; }
+	[Inject] TokenAuthStateProvider AuthStateProvider { get; set; }
 	[Inject] NavigationManager Navigation { get; set; }
 
+	// The app signs in with its own token (TokenAuthStateProvider), so signing out clears that token and the local
+	// database. The template's authentication/logout route can't do it: RemoteAuthenticatorView needs the OIDC
+	// provider this app replaces, and throws.
 	protected override async Task OnInitializedAsync()
 	{
-		//await AuthStateProvider.LogoutAsync(true);
-		await SignOutSessionStateManager.SetSignOutState();
-		Navigation.NavigateTo("authenticatio/logout");
+		await AuthStateProvider.LogoutAsync(true);
+		Navigation.NavigateTo("");
 	}
 }
diff --git a/Shared/LoginDisplay.razor b/Shared/LoginDisplay.razor
index e8aa3cc..c051e3f 100644
--- a/Shared/LoginDisplay.razor
+++ b/Shared/LoginDisplay.razor
@@ -18,6 +18,6 @@
 	[CascadingParameter] CascadingState CascadingState { get; set; }
 	private void BeginSignOut(MouseEventArgs args)
 	{
-		Navigation.NavigateToLogout("authentication/logout");
+		Navigation.NavigateTo("logout");
 	}
 }
\ No newline at end of file