Owner decision 2026-10-04: fix the mismatches and every other mismatch of the same kind.
- One counting rule (Domain/Privacy/Counted), Mastodon's. It is used for a persona's statuses_count, its outbox
totalItems, NodeInfo localPosts and the instance status_count, which used to count four different things. It
counts every post that is neither deleted nor a DM, boosts included, and circle and located posts too (owner
decision). A group's count includes its remote members' posts.
- Users. Personas of banned or deleted roots no longer count, and are not found in search. NodeInfo now gives
activeMonth and activeHalfyear, and the v2 instance gives active_month instead of a constant 0.
- replies_count counts only public and unlisted replies, so it no longer tells anyone that a private reply exists.
Migration _012 recounts it.
- A remote account that deletes itself takes everything out of every count (GoneActors): its likes, downvotes,
reactions and poll votes go and their counters come back, as do its boosts', replies' and quotes' counts, and its
notifications. Lookups, account lists, search and favourited_by no longer show it. Migration _012 applies this to
accounts already gone.
- Deleting a post also deletes its pins and the local boosts of it.
- /stalking gives the same total as following_count. Members are still never listed, and hide_collections is now
always true, since the setting never did anything.
- Joining a community by invitation is following it, so /flock and /groupies agree; leaving unfollows.
- Search. Anyone may search, as on Mastodon; resolve and offset need a sign-in, offset pages, and deleted accounts
are never found.
- notifications/unread_count counts what the list shows, and the owner's follower and following lists page with
Link.
- The instance API advertises what is enforced:
- max_characters, now enforced with a 422;
- max_pinned_statuses = MaxPins;
- the media types and limits MediaService and MediaOptions accept;
- PollService's limits;
- the configured languages;
- no streaming URL until streaming exists.
domain_count counts the servers we have exchanged with; which ones stays unpublished (peers is empty).
- Routes Mastodon answers now answer instead of 404:
- directory, tags/{name}, timelines/link and identity_proofs;
- instance/languages, translation_languages, domain_blocks and privacy_policy;
- the v1 and v2 notification policy, and notification requests.
Also, from phase 3: a recovered password ends /clientapi sessions through a per-root SessionStamp claim instead of
comparing the JWT's whole-second nbf with the change time. That comparison let a token issued in the same second
survive, which made a test flaky.
671 tests pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ELjqpznMFMNrJoJUj6K5p2
391 lines
16 KiB
C#
391 lines
16 KiB
C#
using Microsoft.Extensions.Localization;
|
|
|
|
using MongoDB.Entities;
|
|
|
|
using PrivaPub.ClientModels;
|
|
using PrivaPub.ClientModels.Group;
|
|
using PrivaPub.Models.Federation;
|
|
using PrivaPub.Models.Group;
|
|
using PrivaPub.Resources;
|
|
using PrivaPub.StaticServices;
|
|
|
|
using GroupEntity = PrivaPub.Models.Group.Group;
|
|
using PrivaPub.Federation.Actors;
|
|
using PrivaPub.Federation.Rendering;
|
|
using PrivaPub.Federation.Outbox;
|
|
|
|
namespace PrivaPub.Services
|
|
{
|
|
public interface IGroupUsersService
|
|
{
|
|
Task<WebResult> GetGroup(string actor, CancellationToken token);
|
|
Task<WebResult> GetGroups(string rootUserId, string avatarId, CancellationToken token);
|
|
Task<WebResult> InsertGroup(string rootUserId, InsertGroupForm form, CancellationToken token);
|
|
Task<WebResult> UpdateGroup(string rootUserId, UpdateGroupForm form, CancellationToken token);
|
|
Task<WebResult> JoinGroup(string rootUserId, JoinGroupForm form, CancellationToken token);
|
|
Task<WebResult> LeaveGroup(string rootUserId, GroupMembershipForm form, CancellationToken token);
|
|
Task<WebResult> ApproveMember(string rootUserId, GroupMembershipForm form, CancellationToken token);
|
|
Task<WebResult> GetInvitation(string invitationCode, string invitationPassword, CancellationToken token);
|
|
}
|
|
|
|
public class GroupUsersService : IGroupUsersService
|
|
{
|
|
readonly DbEntities _dbEntities;
|
|
readonly IPasswordHasher _passwordHasher;
|
|
readonly ILocalActorService _localActors;
|
|
readonly IDeliveryService _delivery;
|
|
readonly IStringLocalizer<GenericRes> _localizer;
|
|
readonly ILogger<GroupUsersService> _logger;
|
|
|
|
public GroupUsersService(DbEntities dbEntities,
|
|
IPasswordHasher passwordHasher,
|
|
ILocalActorService localActors,
|
|
IDeliveryService delivery,
|
|
IStringLocalizer<GenericRes> localizer,
|
|
ILogger<GroupUsersService> logger)
|
|
{
|
|
_dbEntities = dbEntities;
|
|
_passwordHasher = passwordHasher;
|
|
_localActors = localActors;
|
|
_delivery = delivery;
|
|
_localizer = localizer;
|
|
_logger = logger;
|
|
}
|
|
|
|
public async Task<WebResult> GetGroup(string actor, CancellationToken token)
|
|
{
|
|
var result = new WebResult();
|
|
try
|
|
{
|
|
var userName = actor?.ToLowerInvariant();
|
|
var group = await _dbEntities.Groups
|
|
.Match(g => g.UserName == userName && !g.DeletionAt.HasValue)
|
|
.ExecuteFirstAsync(token);
|
|
if (group == default)
|
|
return result.Invalidate(_localizer["Group '{0}' not found.", actor], StatusCodes.Status404NotFound);
|
|
result.Data = group;
|
|
return result;
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
_logger.LogError(ex, $"{nameof(GroupUsersService)}.{nameof(GetGroup)}");
|
|
return result.Invalidate(_localizer["Something went wrong."], exception: ex);
|
|
}
|
|
}
|
|
|
|
public async Task<WebResult> GetGroups(string rootUserId, string avatarId, CancellationToken token)
|
|
{
|
|
var result = new WebResult();
|
|
try
|
|
{
|
|
if (!await OwnsAvatar(rootUserId, avatarId, token))
|
|
return result.Invalidate(_localizer["Avatar not found."], StatusCodes.Status404NotFound);
|
|
|
|
var groups = await _dbEntities.Groups
|
|
.Match(g => !g.DeletionAt.HasValue && g.Members.Any(m => !m.IsForeign && m.AvatarId == avatarId))
|
|
.ExecuteAsync(token);
|
|
result.Data = groups.Select(g => ToView(g, avatarId)).ToList();
|
|
return result;
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
_logger.LogError(ex, $"{nameof(GroupUsersService)}.{nameof(GetGroups)}");
|
|
return result.Invalidate(_localizer["Something went wrong."], exception: ex);
|
|
}
|
|
}
|
|
|
|
public async Task<WebResult> InsertGroup(string rootUserId, InsertGroupForm form, CancellationToken token)
|
|
{
|
|
var result = new WebResult();
|
|
try
|
|
{
|
|
if (!await OwnsAvatar(rootUserId, form.AvatarId, token))
|
|
return result.Invalidate(_localizer["Avatar not found."], StatusCodes.Status404NotFound);
|
|
|
|
var userName = form.UserName.ToLowerInvariant();
|
|
if (await _localActors.IsUserNameTaken(userName, token))
|
|
return result.Invalidate(_localizer["The username '{0}' is already take.", userName]);
|
|
|
|
var (privateKey, publicKey) = Keys.NewKeyPair();
|
|
var group = new GroupEntity
|
|
{
|
|
UserName = userName,
|
|
Name = form.Name,
|
|
Description = form.Description,
|
|
Domain = _localActors.BaseAddress,
|
|
PrivateKey = privateKey,
|
|
PublicKey = publicKey,
|
|
Kind = form.IsCommunity ? GroupKind.Community : GroupKind.Circle,
|
|
PostingPolicy = Policy(form.PostingPolicy) ?? PostingPolicy.Followers,
|
|
IsDiscoverable = form.IsDiscoverable,
|
|
ManuallyApprovesMembers = form.ManuallyApprovesMembers,
|
|
OwnerAvatarId = form.AvatarId,
|
|
InvitationCode = NewInvitationCode(),
|
|
HashedInvitationPassword = string.IsNullOrEmpty(form.InvitationPassword) ? default : _passwordHasher.Hash(form.InvitationPassword),
|
|
Members = new() { new GroupMember { AvatarId = form.AvatarId, Role = GroupRole.Owner } }
|
|
};
|
|
group.ID = (string)group.GenerateNewID();
|
|
if (!await _localActors.TryReserveUserName(userName, LocalActorKind.Group, group.ID, token))
|
|
return result.Invalidate(_localizer["The username '{0}' is already take.", userName]);
|
|
var actor = _localActors.FromGroup(group);
|
|
group.Url = actor.Uri;
|
|
group.InboxURL = actor.Inbox;
|
|
group.OutboxURL = actor.Outbox;
|
|
await DB.Default.SaveAsync(group, token);
|
|
|
|
result.Data = ToView(group, form.AvatarId);
|
|
return result;
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
_logger.LogError(ex, $"{nameof(GroupUsersService)}.{nameof(InsertGroup)}");
|
|
return result.Invalidate(_localizer["Something went wrong."], exception: ex);
|
|
}
|
|
}
|
|
|
|
public async Task<WebResult> UpdateGroup(string rootUserId, UpdateGroupForm form, CancellationToken token)
|
|
{
|
|
var result = new WebResult();
|
|
try
|
|
{
|
|
var group = await ManagedGroup(rootUserId, form.AvatarId, form.GroupId, token);
|
|
if (group == default)
|
|
return result.Invalidate(_localizer["Group not found."], StatusCodes.Status404NotFound);
|
|
|
|
if (form.Name != default)
|
|
group.Name = form.Name;
|
|
if (form.Description != default)
|
|
group.Description = form.Description;
|
|
if (form.IsDiscoverable.HasValue)
|
|
group.IsDiscoverable = form.IsDiscoverable.Value;
|
|
if (Policy(form.PostingPolicy) is { } policy)
|
|
group.PostingPolicy = policy;
|
|
if (form.ManuallyApprovesMembers.HasValue)
|
|
group.ManuallyApprovesMembers = form.ManuallyApprovesMembers.Value;
|
|
if (form.RemoveInvitationPassword)
|
|
group.HashedInvitationPassword = default;
|
|
else if (!string.IsNullOrEmpty(form.InvitationPassword))
|
|
group.HashedInvitationPassword = _passwordHasher.Hash(form.InvitationPassword);
|
|
if (form.RegenerateInvitationCode)
|
|
group.InvitationCode = NewInvitationCode();
|
|
group.UpdatedAt = DateTime.UtcNow;
|
|
await DB.Default.SaveAsync(group, token);
|
|
|
|
result.Data = ToView(group, form.AvatarId);
|
|
return result;
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
_logger.LogError(ex, $"{nameof(GroupUsersService)}.{nameof(UpdateGroup)}");
|
|
return result.Invalidate(_localizer["Something went wrong."], exception: ex);
|
|
}
|
|
}
|
|
|
|
public async Task<WebResult> JoinGroup(string rootUserId, JoinGroupForm form, CancellationToken token)
|
|
{
|
|
var result = new WebResult();
|
|
try
|
|
{
|
|
if (!await OwnsAvatar(rootUserId, form.AvatarId, token))
|
|
return result.Invalidate(_localizer["Avatar not found."], StatusCodes.Status404NotFound);
|
|
|
|
var group = await _dbEntities.Groups
|
|
.Match(g => g.InvitationCode == form.InvitationCode && !g.DeletionAt.HasValue)
|
|
.ExecuteFirstAsync(token);
|
|
if (group == default)
|
|
return result.Invalidate(_localizer["Invalid invitation."], StatusCodes.Status404NotFound);
|
|
|
|
if (!string.IsNullOrEmpty(group.HashedInvitationPassword))
|
|
{
|
|
var (verified, _) = string.IsNullOrEmpty(form.InvitationPassword)
|
|
? (false, false)
|
|
: _passwordHasher.Check(group.HashedInvitationPassword, form.InvitationPassword);
|
|
if (!verified)
|
|
return result.Invalidate(_localizer["Invalid password."], StatusCodes.Status406NotAcceptable);
|
|
}
|
|
|
|
if (!group.Members.Any(m => !m.IsForeign && m.AvatarId == form.AvatarId))
|
|
{
|
|
group.Members.Add(new GroupMember { AvatarId = form.AvatarId });
|
|
group.UpdatedAt = DateTime.UtcNow;
|
|
await DB.Default.SaveAsync(group, token);
|
|
}
|
|
await FollowAsMember(group, form.AvatarId, token);
|
|
|
|
result.Data = ToView(group, form.AvatarId);
|
|
return result;
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
_logger.LogError(ex, $"{nameof(GroupUsersService)}.{nameof(JoinGroup)}");
|
|
return result.Invalidate(_localizer["Something went wrong."], exception: ex);
|
|
}
|
|
}
|
|
|
|
// Joining by invitation is following, as a local follow of the group would be: the member counts among its
|
|
// followers (so /groupies and /flock agree) and gets its posts in the home timeline.
|
|
async Task FollowAsMember(GroupEntity group, string avatarId, CancellationToken token)
|
|
{
|
|
var persona = await _localActors.FindById(LocalActorKind.Person, avatarId, token);
|
|
var target = _localActors.FromGroup(group);
|
|
if (persona == default)
|
|
return;
|
|
await DB.Default.Update<Follower>()
|
|
.Match(f => f.LocalActorId == group.ID && f.LocalActorKind == LocalActorKind.Group && f.ActorURI == persona.Uri)
|
|
.Modify(f => f.InboxURL, persona.Inbox)
|
|
.Modify(f => f.SharedInboxURL, persona.SharedInbox)
|
|
.Modify(f => f.IsAccepted, true)
|
|
.Modify(b => b.SetOnInsert(f => f.CreationDate, DateTime.UtcNow))
|
|
.Option(o => o.IsUpsert = true)
|
|
.ExecuteAsync(token);
|
|
await DB.Default.Update<Models.Social.Following>()
|
|
.Match(f => f.AvatarId == persona.Id && f.TargetActorURI == target.Uri)
|
|
.Modify(f => f.TargetAccountId, group.ID)
|
|
.Modify(f => f.TargetIsLocal, true)
|
|
.Modify(f => f.TargetInboxURL, target.Inbox)
|
|
.Modify(f => f.State, Models.Social.FollowState.Accepted)
|
|
.Modify(b => b.SetOnInsert(f => f.CreatedAt, DateTime.UtcNow))
|
|
.Option(o => o.IsUpsert = true)
|
|
.ExecuteAsync(token);
|
|
}
|
|
|
|
public async Task<WebResult> LeaveGroup(string rootUserId, GroupMembershipForm form, CancellationToken token)
|
|
{
|
|
var result = new WebResult();
|
|
try
|
|
{
|
|
if (!await OwnsAvatar(rootUserId, form.AvatarId, token))
|
|
return result.Invalidate(_localizer["Avatar not found."], StatusCodes.Status404NotFound);
|
|
|
|
var group = await _dbEntities.Groups.MatchID(form.GroupId).ExecuteFirstAsync(token);
|
|
if (group == default)
|
|
return result.Invalidate(_localizer["Group not found."], StatusCodes.Status404NotFound);
|
|
if (group.OwnerAvatarId == form.AvatarId)
|
|
return result.Invalidate(_localizer["The owner cannot leave the group."]);
|
|
|
|
group.Members.RemoveAll(m => !m.IsForeign && m.AvatarId == form.AvatarId);
|
|
group.UpdatedAt = DateTime.UtcNow;
|
|
await DB.Default.SaveAsync(group, token);
|
|
// leaving is unfollowing, as joining was following
|
|
var groupUri = _localActors.FromGroup(group).Uri;
|
|
var personaUri = (await _localActors.FindById(LocalActorKind.Person, form.AvatarId, token))?.Uri;
|
|
await DB.Default.DeleteAsync<Models.Social.Following>(f => f.AvatarId == form.AvatarId && f.TargetActorURI == groupUri);
|
|
if (personaUri != default)
|
|
await DB.Default.DeleteAsync<Follower>(f => f.LocalActorId == group.ID && f.LocalActorKind == LocalActorKind.Group && f.ActorURI == personaUri);
|
|
return result;
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
_logger.LogError(ex, $"{nameof(GroupUsersService)}.{nameof(LeaveGroup)}");
|
|
return result.Invalidate(_localizer["Something went wrong."], exception: ex);
|
|
}
|
|
}
|
|
|
|
public async Task<WebResult> ApproveMember(string rootUserId, GroupMembershipForm form, CancellationToken token)
|
|
{
|
|
var result = new WebResult();
|
|
try
|
|
{
|
|
var group = await ManagedGroup(rootUserId, form.AvatarId, form.GroupId, token);
|
|
if (group == default)
|
|
return result.Invalidate(_localizer["Group not found."], StatusCodes.Status404NotFound);
|
|
|
|
var follower = await _dbEntities.Followers
|
|
.Match(f => f.LocalActorId == group.ID && f.LocalActorKind == LocalActorKind.Group && f.ActorURI == form.MemberActorURI)
|
|
.ExecuteFirstAsync(token);
|
|
if (follower == default)
|
|
return result.Invalidate(_localizer["Request not found."], StatusCodes.Status404NotFound);
|
|
|
|
follower.IsAccepted = true;
|
|
await DB.Default.SaveAsync(follower, token);
|
|
if (!group.Members.Any(m => m.IsForeign && m.AvatarId == follower.ActorURI))
|
|
{
|
|
group.Members.Add(new GroupMember { AvatarId = follower.ActorURI, IsForeign = true });
|
|
await DB.Default.SaveAsync(group, token);
|
|
}
|
|
|
|
var actor = _localActors.FromGroup(group);
|
|
var follow = new System.Text.Json.Nodes.JsonObject
|
|
{
|
|
["id"] = follower.FollowActivityURI,
|
|
["type"] = "Follow",
|
|
["actor"] = follower.ActorURI,
|
|
["object"] = actor.Uri
|
|
};
|
|
var accept = ActivityPubRenderer.Accept(actor, follow, $"accept-{follower.ID}-{DateTime.UtcNow.Ticks}");
|
|
await _delivery.Enqueue(actor, new[] { follower.InboxURL }, accept, token);
|
|
return result;
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
_logger.LogError(ex, $"{nameof(GroupUsersService)}.{nameof(ApproveMember)}");
|
|
return result.Invalidate(_localizer["Something went wrong."], exception: ex);
|
|
}
|
|
}
|
|
|
|
public async Task<WebResult> GetInvitation(string invitationCode, string invitationPassword, CancellationToken token)
|
|
{
|
|
var result = new WebResult();
|
|
var group = string.IsNullOrEmpty(invitationCode)
|
|
? default
|
|
: await _dbEntities.Groups.Match(g => g.InvitationCode == invitationCode && !g.DeletionAt.HasValue).ExecuteFirstAsync(token);
|
|
if (group == default)
|
|
return result.Invalidate(_localizer["Invalid invitation."], StatusCodes.Status404NotFound);
|
|
if (!string.IsNullOrEmpty(group.HashedInvitationPassword)
|
|
&& (string.IsNullOrEmpty(invitationPassword) || !_passwordHasher.Check(group.HashedInvitationPassword, invitationPassword).verified))
|
|
return result.Invalidate(_localizer["Invalid password."], StatusCodes.Status406NotAcceptable);
|
|
result.Data = group;
|
|
return result;
|
|
}
|
|
|
|
async Task<GroupEntity> ManagedGroup(string rootUserId, string avatarId, string groupId, CancellationToken token)
|
|
{
|
|
if (!await OwnsAvatar(rootUserId, avatarId, token))
|
|
return default;
|
|
var group = await _dbEntities.Groups.MatchID(groupId).ExecuteFirstAsync(token);
|
|
if (group == default || group.DeletionAt.HasValue)
|
|
return default;
|
|
var role = group.Members.FirstOrDefault(m => !m.IsForeign && m.AvatarId == avatarId)?.Role;
|
|
return role is GroupRole.Owner or GroupRole.Moderator ? group : default;
|
|
}
|
|
|
|
async Task<bool> OwnsAvatar(string rootUserId, string avatarId, CancellationToken token) =>
|
|
!string.IsNullOrEmpty(rootUserId) && !string.IsNullOrEmpty(avatarId)
|
|
&& await _dbEntities.RootToAvatars.Match(ra => ra.RootId == rootUserId && ra.AvatarId == avatarId).ExecuteAnyAsync(token);
|
|
|
|
static PostingPolicy? Policy(string value) => value?.ToLowerInvariant() switch
|
|
{
|
|
"anyone" => PostingPolicy.Anyone,
|
|
"moderators" => PostingPolicy.Moderators,
|
|
"followers" => PostingPolicy.Followers,
|
|
_ => (PostingPolicy?)null
|
|
};
|
|
|
|
static string NewInvitationCode() => $"{Guid.NewGuid():N}{Guid.NewGuid():N}";
|
|
|
|
ViewGroup ToView(GroupEntity group, string avatarId)
|
|
{
|
|
var actor = _localActors.FromGroup(group);
|
|
var isManager = group.Members.Any(m => !m.IsForeign && m.AvatarId == avatarId && m.Role is GroupRole.Owner or GroupRole.Moderator);
|
|
return new ViewGroup
|
|
{
|
|
Id = group.ID,
|
|
UserName = group.UserName,
|
|
Name = group.Name,
|
|
Description = group.Description,
|
|
Url = actor.Uri,
|
|
Handle = actor.Handle,
|
|
IsCommunity = group.Kind == GroupKind.Community,
|
|
PostingPolicy = group.PostingPolicy.ToString().ToLowerInvariant(),
|
|
IsDiscoverable = group.IsDiscoverable,
|
|
ManuallyApprovesMembers = group.ManuallyApprovesMembers,
|
|
IsOwner = group.OwnerAvatarId == avatarId,
|
|
InvitationCode = isManager ? group.InvitationCode : default,
|
|
IsPasswordRequired = !string.IsNullOrEmpty(group.HashedInvitationPassword),
|
|
MembersCount = group.Members.Count,
|
|
CreationDate = group.CreationDate
|
|
};
|
|
}
|
|
}
|
|
}
|